https://bugzilla.redhat.com/show_bug.cgi?id=2264218 --- Comment #3 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #1) > 1. The spec file uploaded separately doesn't match the spec file in the > SRPM, please make sure they match. > I probably forgot to regenerate before uploading, sorry > > URL: https://gitlab.freedesktop.org/pipewire/helvum > > Source: https://gitlab.freedesktop.org/pipewire/helvum/-/archive/%{version}/helvum-%{version}.tar.gz > > 2. You can replace this with: > > ``` > URL: https://gitlab.freedesktop.org/pipewire/helvum > Source: %{url}/-/archive/%{version}/helvum-%{version}.tar.gz > ``` > Ah, of course > To make it more concise. > > 3. You might want to validate the AppStream metadata with appstream as well, > it is now used everywhere instead of appstream-glib (with one exception): > > ``` > BuildRequires: appstream > (...) > appstreamcli validate --no-net path-to-file > ``` Will update, thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2264218 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202264218%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
