https://bugzilla.redhat.com/show_bug.cgi?id=2253360 --- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Benson Muite from comment #6) > a) An additional license needs to be specified: > Boost Software License 1.0 > -------------------------- > papilo-2.1.4/src/papilo/misc/extended_euclidean.hpp > This is used in: > src/papilo/presolvers/SimpleSubstitution.hpp > which is installed in libpapilo-devel Good catch! Added. > c) libpapilo does not have the license files and does not require the papilo > package, perhaps it > should have the license files and the papilo package should require > libpapilo? Yes, you are quite right. Fixed. > d) The program duplicates has a generic name, but it does not match anything: > dnf provides '/usr/bin/duplicates' > Last metadata expiration check: 0:02:09 ago on Wed 14 Feb 2024 09:29:26 AM > UTC. > Error: No matches found. If searching for a file, try specifying the full > path or using a wildcard prefix ("*/") at the beginning. That is very generic. Do you think I should change it? We could make it papilo-duplicates, I suppose. I am mostly interested in the library interface, anyway, not the command line tools. For added fun: $ duplicates usage: ./check_duplicates instance1.mps instance2.mps - check for duplicates ./check_duplicates instance1.mps - compute unique hash for instance So it thinks its name is "./check_duplicates"! > e) Unclear why one gets: > Note: No known owner of /usr/lib64/cmake Yes. Your package gets that, too, and both packages have a dependency on cmake-filesystem, so something broke somewhere. I wonder if the switch to dnf5 is responsible somehow. I have also added man pages generated by help2man. New URLs: Spec URL: https://jjames.fedorapeople.org/papilo/papilo.spec SRPM URL: https://jjames.fedorapeople.org/papilo/papilo-2.1.4-1.fc41.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2253360 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202253360%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
