https://bugzilla.redhat.com/show_bug.cgi?id=2257285 Roman Inflianskas <rominf@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(code@musicinmybra | |in.net) --- Comment #20 from Roman Inflianskas <rominf@xxxxxxxx> --- (In reply to Ben Beasley from comment #16) > (In reply to Roman Inflianskas from comment #15) > > ACCEPTED > > Thank you very much for the review! You are welcome! > > There are two minor points, feel free to skip them. > > > > 1. > > I am not sure whether is fine to simplify: > > ``` > > (BSD-3-Clause AND MIT) AND BSD-3-Clause AND MIT > > ``` > > to: > > ``` > > BSD-3-Clause AND MIT > > ``` > > ? > > > > However, considering that you are aware of this, I assume I miss something > > and > > it is OK. > > This is kind of indirectly addressed in > https://docs.fedoraproject.org/en-US/legal/license-field/ > #_special_rules_for_or_expressions: > > “A license should normally appear only once in the License: tag license > expression. But if the license expression includes an OR sub-expression, > that OR sub-expression is treated as though it were a single license for > purposes of this rule.” > > Since (BSD-3-Clause AND MIT) is a conjunctive/AND expression, we can discard > the grouping to get “BSD-3-Clause AND MIT AND BSD-3-Clause AND MIT” and then > de-duplicate. Thanks for explanation! > > > > 2. > > Spellchecker doens't like `de/compression`. I would probably add: > > ``` > > addFilter(r"spelling-error.*de") > > ``` > > to > > `python-cramjam.rpmlintrc` to silence it: description is short and will > > likely stay the same, so chance for missing real mistake is small. > > I used to try to keep clean rpmlint output for my packages using rpmlintrc > files, but abandoned the practice in the rpmlint 1.x-2.x transition. It’s > worth trying it again, I guess. I’ll try the suggested filter and see if it > works as expected. :+1 I am co-maintainer of python-aiokafka (https://src.fedoraproject.org/rpms/python-aiokafka) and I am actively working on refreshing it. The last missing piece is to add support for compression by packaging extras on all supported Fedora versions. Extras depend on python-cramjam: https://github.com/aio-libs/aiokafka/blob/bb15ecfb4c85026b2bded912ab7ba7c7e1db3271/pyproject.toml#L36. I checked that python-cramjam builds on all supported Fedora versions. Could you please create a new-package update for Fedora 38-40? I am ready to do it myself, if you add me as co-maintainer. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2257285 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257285%23c20 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
