https://bugzilla.redhat.com/show_bug.cgi?id=2262276 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial perusal of the sources gives me a few pauses for concern: * it looks like there's a systemd unit: https://github.com/aws/amazon-ssm-agent/blob/mainline/packaging/linux/amazon-ssm-agent.service the systemd unit should have a "ConditionVirtualization=amazon" stanza so it doesn't activate on non-AWS. Additionally, we need a preset for this. * this stuff makes me nervous: ** https://github.com/aws/amazon-ssm-agent/tree/mainline/agent/plugins/configurepackage ** https://github.com/aws/amazon-ssm-agent/tree/mainline/agent/plugins/downloadcontent * this selfupdate code needs to be killed: https://github.com/aws/amazon-ssm-agent/blob/mainline/agent/plugins/updatessmagent/updateagent.go can you please take a look at this further? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2262276 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262276%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
