[Bug 2208398] Review Request: python-pyasn - Offline IP address to Autonomous System Number lookup module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2208398



--- Comment #6 from Davide Cavalca <davide@xxxxxxxxxxxx> ---
Thanks for the review!

(In reply to Petr Menšík from comment #3)
> Blocking issue found is the package does not contain License file at all.

I've updated the license tag to the best of my understanding. The actual
license file is included in
/usr/lib64/python3.12/site-packages/pyasn-1.6.1.dist-info/LICENSE

(In reply to Petr Menšík from comment #4)
> Not sure whether using suffix .py for commands present in path is a good idea. Usually I would expect it not present, but it might be some tools depend on those names or upstream wants them this way.

I thought about it but I didn't want to deviate from upstream. Looking at
`/usr/bin` on my Fedora box there's quite a few things there with various
suffixes (including .py) so I think this is probably fine in practice.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2208398

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202208398%23c6
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux