https://bugzilla.redhat.com/show_bug.cgi?id=2252778 Orion Poplawski <orion@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(orion@xxxxxxxx) | --- Comment #5 from Orion Poplawski <orion@xxxxxxxx> --- Sorry for the delay, missed this over the holidays. I would suggest: Source: https://github.com/graphql-python/gql/archive/v%{version}/%{name}-%{version}.tar.gz Still no %check. It looks like upstream already does not run tests that need online resources unless --run-online is given to pytest. No need to remove .egg-info Are the Requires not picked up automatically? This is what I get without them: Requires: (python3.12dist(anyio) < 5~~ with python3.12dist(anyio) >= 3) (python3.12dist(backoff) < 3~~ with python3.12dist(backoff) >= 1.11.1) (python3.12dist(graphql-core) < 3.3~~ with python3.12dist(graphql-core) >= 3.2) (python3.12dist(yarl) < 2~~ with python3.12dist(yarl) >= 1.6) /usr/bin/python3 python(abi) = 3.12 Use %pyproject_save_files Do rm -r gql-checker in %prep to make it clear it's not needed/used. This is what I have: https://fedorapeople.org/~orion/python-gql.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2252778 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202252778%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
