[Bug 2262694] Review Request: materialx - Open standard for the exchange of rich material

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2262694



--- Comment #16 from Carlos Rodriguez-Fernandez <carlosrodrifernandez@xxxxxxxxx> ---
Luya, thank you so much for all the updates.

Inspecting the packages I found these files being installed in python3-%{name}
(cut for brevity):


/usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXCore.cpython-312-x86_64-linux-gnu.so
/usr/lib64/python3.12/site-packages/MaterialX/PyMaterialXFormat.cpython-312-x86_64-linux-gnu.so
...
/usr/lib64/python3.12/site-packages/MaterialX/__init__.py
/usr/lib64/python3.12/site-packages/MaterialX/__pycache__
/usr/lib64/python3.12/site-packages/MaterialX/__pycache__/__init__.cpython-312.opt-1.pyc
...
/usr/lib64/python3.12/site-packages/MaterialX/_scripts
/usr/lib64/python3.12/site-packages/MaterialX/_scripts/README.md
...
/usr/lib64/python3.12/site-packages/MaterialX/colorspace.py
/usr/lib64/python3.12/site-packages/MaterialX/datatype.py
/usr/lib64/python3.12/site-packages/MaterialX/main.py
/usr/lib64/python3.12/site-packages/MaterialX/usr
/usr/lib64/python3.12/site-packages/MaterialX/usr/share
/usr/lib64/python3.12/site-packages/MaterialX/usr/share/materialx
/usr/lib64/python3.12/site-packages/MaterialX/usr/share/materialx/README.md
/usr/lib64/python3.12/site-packages/MaterialX/usr/share/materialx/bxdf
/usr/lib64/python3.12/site-packages/MaterialX/usr/share/materialx/bxdf/disney_brdf_2012.mtlx
...


Notice that `/usr/lib64/python3.12/site-packages/MaterialX/usr/share/materialx`
folder with a lot of the resources that are already in /usr/share/materialx. Is
that a bug?



Also, I opened some of the "Scripts" *.py files you are installing in the top
package and I found some dependencies missing in the SPEC file:
*.py in %{name} depends on python libraries provided in python3-%{name}, which
depends on %{name}-libs, which may be not of great help without the
/usr/share/materialx files.


This is an idea of how to restructure this, let me know what you think:

package: libmaterialx (general naming for libs)
* .so. files
* /usr/share/materialx files
* docs
- doesn't depend on anything and stand on its own

subpackage: python3-libmaterialx (many packages are named this way:
python3-libXYZ)
* python libs and cpython so files
- depends on libmaterialx

subpackage: libmaterialx-tools (some are named this way, e.g., libbpf-tools)
* the *.py tools installed in /usr/bin
- depends on python3-libmaterialx

subpackage: libmaterialx-devel
* development files
- depends on libmaterialx


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2262694

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262694%23c16
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux