https://bugzilla.redhat.com/show_bug.cgi?id=2195959 --- Comment #5 from Davide Cavalca <davide@xxxxxxxxxxxx> --- Thanks! > a) Please modify spec file to add > %dir %{_datadir}/%{name} > in the files section Fixed > b) Please also package the copyright file This is already included in %license > c) typedef.h seems to be under GPL 1.0 or later Fixed > d) Warning when building: These seem harmless in practice. I'd put up a PR but there isn't an upstream repo or an obvious contribution workflow. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2195959 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202195959%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue