[Bug 2259602] Review Request: config-kernel - An easy way to edit kernel configuration files and templates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2259602



--- Comment #13 from pjp <pj.pandit@xxxxxxxx> ---
Hello Benson,

* Thanks so much for the review, I appreciate it.

(In reply to Benson Muite from comment #12)
> c) Two warnings
> config-kernel.x86_64: W: unused-direct-shlib-dependency /usr/bin/configk /lib64/libfl.so.2

* Hmmn, I did not get this warning.

> config-kernel.x86_64: W: position-independent-executable-suggested
> /usr/bin/configk
> 
> rpmlint -e position-independent-executable-suggested
> position-independent-executable-suggested:
> This executable should be position independent (all binaries should).  Check
> that it is built with -fPIE/-fpie in compiler flags and -pie in linker flags.
> 
> Maybe try split the makefile to have a linking step rather than building and
> linking in one command. This would allow -pie to be added to the linker command.


* I tried adding "-pie -PIE -pic -PIC" to $CFLAGS & $LDFLAGS both, it does not
help to fix the warning.

===
# dnf info bison-devel
Installed Packages
Source       : bison-3.8.2-5.fc39.src.rpm
Repository   : @System
>From repo    : fedora
Summary      : -ly library for development using Bison-generated parsers
URL          : http://www.gnu.org/software/bison/
Description  : The bison-devel package contains the -ly library sometimes used
by
             : programs using Bison-generated parsers.  If you are developing
programs
             : using Bison, you might want to link with this library.  This
library
             : is not required by all Bison-generated parsers, but may be
employed by
             : simple programs to supply minimal support for the generated
parsers.
#
# rpmls bison-devel
-rw-r--r--  /usr/lib64/liby.a
drwxr-xr-x  /usr/share/doc/bison-devel
-rw-r--r--  /usr/share/doc/bison-devel/COPYING
# 
# file /usr/lib64/liby.a 
/usr/lib64/liby.a: current ar archive
===

* It looks like '-ly' Bison yacc(1) library is a static object archive, not a
shared library. Likely that is causing generation of a non-position-independent
binary. Not sure how to fix it.


Thank you.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2259602

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259602%23c13
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux