https://bugzilla.redhat.com/show_bug.cgi?id=2263322 --- Comment #2 from Jan Grulich <jgrulich@xxxxxxxxxx> --- (In reply to Jan Grulich from comment #1) > 1) Didn't mean to submit it :) 1) The package should have name consistent with other Qt modules so it should be qt6-qtmqtt and not only qtmqtt. 2) Rawhide is currently on Qt 6.6.1 so please update it to match the Qt version there. 3) The source should point to link where you can get the tarball, in this case it should be something like https://github.com/qt/qtmqtt/archive/%{version}/%{name}-%{version}.tar.gz 4) BuildRequires: qt6-qtdeclarative-devel → shouldn't be needed as I can see in the CMakeLists.txt that it is used only for tests 5) Maybe extend the description with more information, something from https://doc.qt.io/qt-6/qtmqtt-index.html for example. 6) Both -examples and -devel are missing "Requires: %{name}%{?_isa} = %{version}-%{release}" to depend on the main package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2263322 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202263322%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
