[Bug 2262135] Review Request: Qualcomm Remote Filesystem Service Implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2262135



--- Comment #7 from Javier Martinez Canillas <fmartine@xxxxxxxxxx> ---
(In reply to Nicolas Chauvet (kwizart) from comment #6)
> if debugging or emulating, it still good to have a local build, but the
> packager guideline also stipulate to have a package generally useful
> Having an aarch64 only build would prevent the package to end in any
> non-aarch64 produced Fedora deliverable media.
> 
> For the unit file condition, you can have a look at mcelog on x86_64:
> systemctl cat mcelog
> 
> Namely: ConditionPathExists=!/sys/module/edac_mce_amd/initstate
> 
> Of course, you need to find a path that can discriminate your particular
> device.

This is for most Windows-on-ARM QC based laptops and QC based Chromebooks.
It would be hard to maintain the allow list of devices using a combination
of DMI information and Device Tree compatible strings (I can't think of any
other way to discriminate).

Not worth it in my opinion.

> This is particularly useful to avoid any error on non-qcom aarch64 devices
> (or even qcom that do not need this driver).
> 
> An even better alternative is to use service activation with udev. (we use
> that for the nvidia driver at rpmfusion), like
> cat /usr/lib/udev/rules.d/10-nvidia.rules
> SUBSYSTEM=="pci", ATTRS{vendor}=="0x10de", ATTRS{class}=="0x030[02]00",
> TAG+="systemd", ENV{SYSTEMD_WANTS}="nvidia-fallback.service" 
>

This is a good idea and can be done as a follow-up. For now the service files
are not enabled by default anyways and have to be manually enabled / started.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2262135

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262135%23c7
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux