https://bugzilla.redhat.com/show_bug.cgi?id=2262694 --- Comment #6 from Carlos Rodriguez-Fernandez <carlosrodrifernandez@xxxxxxxxx> --- Regarding "BSD" in the license: * The License should be encoded using the SPDX ids: https://spdx.org/licenses/ * It looks to me that the libs subpackage license is only Apache-2.0. The project references a THIRD-PARTY.md file with detailed licenses "of third-party projects that have been imported or incorporated into MaterialX". For what I can detect, these are the license listed there using the SPDX ids: They are all MIT except these: ambientcg CC0-1.0 catch BSL-1.0 cgltf MIT glfw MIT-0? Zlib? nanogui BSD-4-Clause openimageio BSD-3-Clause openshadinglanguage BSD-3-Clause poly-haven CC0-1.0 pybind11 BSD-4-Clause It looks to me they are all for the top package (where the datadir is going), and should be listed with an AND. The THIRD-PARTY.md file should also be included as a `%license` as well. Relevant linting errors and warnings: materialx.src: E: summary-too-long Open standard for the exchange of rich material and look-development content across applications and renderers. materialx.x86_64: E: summary-too-long Open standard for the exchange of rich material and look-development content across applications and renderers. materialx.src: W: summary-ended-with-dot Open standard for the exchange of rich material and look-development content across applications and renderers. materialx.x86_64: W: summary-ended-with-dot Open standard for the exchange of rich material and look-development content across applications and renderers. materialx.x86_64: W: spurious-executable-perm /usr/share/doc/materialx/CHANGELOG.md materialx.x86_64: W: spurious-executable-perm /usr/share/doc/materialx/README.md materialx.x86_64: W: spurious-executable-perm /usr/share/doc/materialx/SECURITY.md materialx.x86_64: E: script-without-shebang /usr/share/licenses/materialx/LICENSE materialx-devel.x86_64: W: no-documentation materialx.x86_64: E: no-binary # this one will be the case, unless the python scripts are included. We will need a second pair of eyes for this one. materialx.spec:76: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 76) materialx.src: E: description-line-too-long MaterialX is an open standard for the exchange of rich material and look-development content across applications and renderers. materialx.x86_64: E: description-line-too-long MaterialX is an open standard for the exchange of rich material and look-development content across applications and renderers. materialx-libs.x86_64: E: description-line-too-long MaterialX is an open standard for the exchange of rich material and look-development content across applications and renderers. 5 packages and 0 specfiles checked; 12 errors, 17 warnings, 12 badness; has taken 2.6 s -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2262694 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262694%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
