https://bugzilla.redhat.com/show_bug.cgi?id=2258867 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is not quite correctly handled * No serious issues from rpmlint The only issue I see missing is that since you're bundling for now (as we discussed in person, you want to do the devendoring later), you'll need to document all the license tags for all the bundled components in the License field. See: https://docs.fedoraproject.org/en-US/legal/license-field/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2258867 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202258867%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue