https://bugzilla.redhat.com/show_bug.cgi?id=2260350 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks for the review! > - dircpy-fix-metadata.diff removes benchmarking dependencies. This is a > reasonable thing to do downstream, but a spec-file comment, even as simple as > “Downstream-only: remove benchmarking dependencies” would be very helpful, > and would satisfy There are already these two comments that explain what the metadata patch is about, it looks like you missed them? # * drop benchmarks and benchmark-only dependencies # * drop dependencies for tests that require internet connectivity -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2260350 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260350%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
