https://bugzilla.redhat.com/show_bug.cgi?id=2240336 --- Comment #5 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Artur Frenszek-Iwicki from comment #4) > rpmlint complains: > > cvt12.x86_64: W: position-independent-executable-suggested /usr/bin/cvt12 > Looking at the build log, while Fedora's CFLAGS are used during the build, > this is not the case with LDFLAGS. > You can use CFLAGS="$CFLAGS $LDFLAGS" in the %make_build invocation, or - > looking at how simplistic > the upstream Makefile is - you could just call gcc directly. Done. > By the way, since upstream does not ship a separate license file, you can > use the following awk snippet > to extract the opening comment, which contains the license text, from the > source code: > > awk '1;/\*\//{exit}' < cvt12.c > LICENSE This is not required and the file this produces still has C comments in it. Spec URL: https://rathann.fedorapeople.org/review/cvt12/cvt12.spec SRPM URL: https://rathann.fedorapeople.org/review/cvt12/cvt12-0%5e20221228git6f66135-2.fc38.src.rpm * Thu Feb 01 2024 Dominik Mierzejewski <dominik@xxxxxxxxxxxxxx> 0^20221228git6f66135-2 - ensure Fedora LDFLAGS are also used during build Thanks for the tips. Is there anything else preventing this package from being approved? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2240336 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202240336%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
