Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: R-BSgenome.Dmelanogaster.FlyBase.r51 - osophila melanogaster genome (FlyBase r5.1) https://bugzilla.redhat.com/show_bug.cgi?id=248678 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-01-18 16:11 EST ------- Not much to say here. However, as with the previous genome package you submitted, could you drop the dist tag and do the magic to get only one copy of this package in the distribution? * source files match upstream: 6c76546e300f5325d1e115809db62894aa1f11f598b940f5206ac1d805a077f8 BSgenome.Dmelanogaster.FlyBase.r51_1.3.1.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint has only the usual R complaints. * final provides and requires are sane: R-BSgenome.Dmelanogaster.FlyBase.r51 = 1.3.1-1.fc9 = /bin/sh R * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets OK (R package registration) * acceptable content * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review