https://bugzilla.redhat.com/show_bug.cgi?id=2259602 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #2 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > License: GPLv2+ Old Callaway-style tag. New packages should use SPDX identifiers for licences. The SPDX equivalent of this is "GPL-2.0-or-later". https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names > Group: Application Not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > %clean > rm -rf $RPM_BUILD_ROOT Don't do this. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > %global debug_package %{nil} No. We want debuginfo in Fedora. Patch the Makefile so it respects Fedora's CFLAGS. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_debuginfo_packages > %files > %defattr (-,root,root,-) These are the defaults. No need to set them. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions > %files > #%license add-license-file-here > %doc README.md COPYING The COPYING file should be marked as %license, not %doc. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2259602 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259602%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
