https://bugzilla.redhat.com/show_bug.cgi?id=2261953 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Maxwell G from comment #2) > - The URL is wrong. It should be https://github.com/mdomke/python-ulid as > far as I can tell. You’re right. I got sloppy editing the spec file I based this on. Thanks for noticing. I’ll fix it. > - There are unicode quotes in the comment at the top of the specfile and > unicode bullet points in the common_description. I noticed because the Copr > specfile page apparently does not handle unicode encoding properly. I would > personally use standard ASCII quotes and * or - for bullet points, but > that's up to you. I like nice Unicode glyphs, and I think we’re far enough into the 21st century that we shouldn’t have to stick with ASCII, but I don’t feel really strongly about it in this particular case. Since I plan to ask you to co-maintain this package, I don’t mind hewing to your preference here. > - I would keep the ulid binary and add `Conflicts: golang-github-oklog-ulid` > or maybe rename it to /usr/bin/python-ulid. (I prefer the first solution but > would accept either.) I don't think removing it completely is the right > solution. The packaging guidelines are kind of bureaucratic here: they would like me to first approach both upstreams about renaming[1], then once I have convinced them both to respond and neither wants to change, either go try to build consensus with all the other distros[1] or add the Conflicts, which I *have to do in both packages*[2]. Obviously, I don’t want to block this review and the python-pydantic-extra-types update on an extended discussion process. I’ll start by filing the issues and seeing if there is a prompt response while I consider what to do. If I go ahead and add the Conflicts, I need to send a PR to https://src.fedoraproject.org/rpms/golang-github-oklog-ulid to add it there, too. I also need to consider whether the conflicting binary should be split into its own subpackage separate from the library in order to reduce the scope of the conflict, and if so, what I should call it? python-ulid-tool? I shouldn’t use python-ulid for the subpackage name, because that is the same as the base package name for a hypothetical future package of https://pypi.org/project/ulid/, should it somehow spring back to life… If I go ahead and rename the binary, things are a lot tidier, but I also feel like I am straying farther from the guidelines by not trying to build a cross-distro consensus first – but is this even practical when nobody else has this problem right now? Here’s a quick survey of a few other distros: - Arch has only the Python package, and it provides /usr/bin/ulid: https://archlinux.org/packages/extra/any/python-ulid/ - openSUSE has neither package - Debian and Ubuntu have only the golang package, and it includes only the library, not /usr/bin/ulid: https://packages.ubuntu.com/noble/all/golang-github-oklog-ulid-dev/filelist - Gentoo has neither package At the moment, I’m leaning toward the Conflicts, golang-github-oklog-ulid PR, and tool subpackage approach. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/#_approaching_upstream [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/#_incompatible_binary_files_with_conflicting_naming_and_stubborn_upstreams -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2261953 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202261953%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
