https://bugzilla.redhat.com/show_bug.cgi?id=2261953 Maxwell G <maxwell@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxwell@xxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |maxwell@xxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Maxwell G <maxwell@xxxxxxx> --- Hmm, this naming situation is a bit of mess, but you did handle it as best as possible and in compliance with the guidelines. Maxwell's Python Package Review Template ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The license text is included and marked with %license. - [x] The package builds successfully in mock. - [x] The package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The packager considers avoiding confusing `%foo_name` macros. (Not a blocker) - [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name - [x] The pyproject macros are used. - [x] There are no bundled libraries. - [x] The package complies with the Python and general Packaging Guidelines. Other problems: - The URL is wrong. It should be https://github.com/mdomke/python-ulid as far as I can tell. - There are unicode quotes in the comment at the top of the specfile and unicode bullet points in the common_description. I noticed because the Copr specfile page apparently does not handle unicode encoding properly. I would personally use standard ASCII quotes and * or - for bullet points, but that's up to you. - I would keep the ulid binary and add `Conflicts: golang-github-oklog-ulid` or maybe rename it to /usr/bin/python-ulid. (I prefer the first solution but would accept either.) I don't think removing it completely is the right solution. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2261953 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202261953%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
