Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: remctl - GSSAPI secured remote command execution https://bugzilla.redhat.com/show_bug.cgi?id=428642 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-01-18 13:05 EST ------- Well, I have only did a quick glance at your spec file as rebuild failed on dist-f9. For general packaging guidelines, please refer to http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines ? Disttag - Please consider to use %{?dist} tag. http://fedoraproject.org/wiki/Packaging/DistTag * Missing BR - Rebuild failed on dist-f9. http://koji.fedoraproject.org/koji/taskinfo?taskID=357485 From build.log, at least 'perl(ExtUtils::MakeMaker)' is missing from BuildRequires. ! Note 'perl(ExtUtils::MakeMaker)' is provides by perl-ExtUtils-MakeMaker rpm, however for perl modules dependency please don't write the rpm names but write the module names needed. ref: http://fedoraproject.org/wiki/Packaging/Perl * Setup - Please make %setup quiet. * Man pages section - Usually man pages with section 3 are for the explanation of libraries/functions and they should be in -devel subpackage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review