https://bugzilla.redhat.com/show_bug.cgi?id=2254928 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |jplesnik@xxxxxxxxxx Status|NEW |ASSIGNED --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-requires perl(IO::Async::Loop) - lib/Net/Async/SOCKS.pm:36 perl(IO::Async::Stream) - lib/Net/Async/SOCKS.pm:37 perl(Protocol::SOCKS::Client) - lib/Net/Async/SOCKS.pm:34 perl(Protocol::SOCKS::Constants) - lib/Net/Async/SOCKS.pm:35 TODO: Remove perl(Test::Refcount), it is not used in code $ rpm -qp --requires perl-Net-Async-SOCKS-0.003-2.fc40.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(IO::Async::Loop) 1 perl(IO::Async::Stream) 1 perl-libs 1 perl(Protocol::SOCKS::Client) 1 perl(Protocol::SOCKS::Constants) 1 perl(strict) 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-Net-Async-SOCKS-0.003-2.fc40.noarch.rpm | sort | uniq -c 1 perl(Net::Async::SOCKS) = 0.003 1 perl-Net-Async-SOCKS = 0.003-2.fc40 Binary provides are Ok. $ rpmlint ./perl-Net-Async-SOCKS* ================================= rpmlint session starts ========================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 perl-Net-Async-SOCKS.noarch: W: incoherent-version-in-changelog 0.04-2 ['0.003-2.fc40', '0.003-2'] === 2 packages and 1 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s ========= FIX: Update different version in changelog TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' item. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2254928 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254928%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
