https://bugzilla.redhat.com/show_bug.cgi?id=2254923 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED CC| |jplesnik@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-requires perl(POSIX) - lib/Test/HTTP/LocalServer.pm:13 perl(vars) - lib/Test/HTTP/LocalServer.pm:433 perl(warnings) - t/00-load.t:4 $ rpm -qp --requires perl-Test-HTTP-LocalServer-0.75-2.fc40.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(Cwd) 1 perl(File::Basename) 1 perl(File::Spec) 1 perl(File::Temp) 1 perl(FindBin) 1 perl(HTTP::Daemon) >= 6.05 1 perl(HTTP::Tiny) 1 perl-libs 1 perl(strict) 1 perl(Time::HiRes) 1 perl(URI::URL) 1 perl(vars) 1 perl(:VERSION) >= 5.8.0 Binary requires FIX: Please add run-requires perl(CGI) - lib/Test/HTTP/log-server:5 perl(Getopt::Long) - lib/Test/HTTP/log-server:7 perl(HTTP::Request::AsCGI) - lib/Test/HTTP/log-server:6 perl(HTTP::Response) - used in lib/Test/HTTP/log-server perl(POSIX) - lib/Test/HTTP/LocalServer.pm:13 perl(Socket) - lib/Test/HTTP/log-server:8 perl(URI) - lib/Test/HTTP/log-server:4 $ rpm -qp --provides perl-Test-HTTP-LocalServer-0.75-2.fc40.noarch.rpm | sort | uniq -c 1 perl(Test::HTTP::LocalServer) = 0.75 1 perl-Test-HTTP-LocalServer = 0.75-2.fc40 Binary provides are Ok. $ rpmlint ./perl-Test-HTTP-LocalServer* ============================== rpmlint session starts ============================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 perl-Test-HTTP-LocalServer.noarch: E: wrong-script-end-of-line-encoding /usr/share/perl5/vendor_perl/Test/HTTP/cookie-server perl-Test-HTTP-LocalServer.noarch: W: unexpanded-macro %description -l C %ENV perl-Test-HTTP-LocalServer.src: W: unexpanded-macro %description -l C %ENV perl-Test-HTTP-LocalServer.noarch: W: incoherent-version-in-changelog 0.04-2 ['0.75-2.fc40', '0.75-2'] 2 packages and 1 specfiles checked; 1 errors, 3 warnings, 1 badness; has taken 0.2 s Rpmlint is ok FIX: Update different version in changelog FIX: Remove wrong script end of line encoding e.g. perl -pi -e 's/\r//' lib/Test/HTTP/cookie-server TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. You can use: %{perl_vendorlib}/Test/HTTP* %{_mandir}/man3/Test::HTTP* Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254923 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254923%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
