https://bugzilla.redhat.com/show_bug.cgi?id=2251479 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #9 from Petr Pisar <ppisar@xxxxxxxxxx> --- TODO: I think that many BuildRrequires are not needed, because no packaged code is executed at build time (e.g. perl(File::Compare)), but do as you like. $ rpmlint perl-File-Unpack2.spec ../SRPMS/perl-File-Unpack2-1.0-1.fc40.src.rpm ../RPMS/x86_64/perl-File-Unpack2-1.0-1.fc40.x86_64.rpm ../RPMS/x86_64/file-unpack-1.0-1.fc40.x86_64.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 file-unpack.x86_64: E: spelling-error ('frontend', '%description -l en_US frontend -> fronted, front end, front-end') file-unpack.x86_64: E: spelling-error ('perl', '%description -l en_US perl -> Perl, peel, perk') perl-File-Unpack2.x86_64: E: spelling-error ('unpacker', 'Summary(en_US) unpacker -> unpacked, unpack er, unpack-er') perl-File-Unpack2.x86_64: E: spelling-error ('unpacker', '%description -l en_US unpacker -> unpacked, unpack er, unpack-er') perl-File-Unpack2.x86_64: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gs') perl-File-Unpack2.x86_64: E: spelling-error ('cpio', '%description -l en_US cpio -> CPI') perl-File-Unpack2.x86_64: E: spelling-error ('iso', '%description -l en_US iso -> ISO, is, so') perl-File-Unpack2.x86_64: E: spelling-error ('lzma', '%description -l en_US lzma -> lama') perl-File-Unpack2.x86_64: E: spelling-error ('rar', '%description -l en_US rar -> arr, ear, tar') perl-File-Unpack2.x86_64: E: spelling-error ('unpackable', '%description -l en_US unpackable -> unpack able, unpack-able, unshockable') perl-File-Unpack2.src: E: spelling-error ('unpacker', 'Summary(en_US) unpacker -> unpacked, unpack er, unpack-er') perl-File-Unpack2.src: E: spelling-error ('unpacker', '%description -l en_US unpacker -> unpacked, unpack er, unpack-er') perl-File-Unpack2.src: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gs') perl-File-Unpack2.src: E: spelling-error ('cpio', '%description -l en_US cpio -> CPI') perl-File-Unpack2.src: E: spelling-error ('iso', '%description -l en_US iso -> ISO, is, so') perl-File-Unpack2.src: E: spelling-error ('lzma', '%description -l en_US lzma -> lama') perl-File-Unpack2.src: E: spelling-error ('rar', '%description -l en_US rar -> arr, ear, tar') perl-File-Unpack2.src: E: spelling-error ('unpackable', '%description -l en_US unpackable -> unpack able, unpack-able, unshockable') file-unpack.x86_64: W: no-manual-page-for-binary file-unpack-deep file-unpack.x86_64: W: no-manual-page-for-binary file_unpack file-unpack.x86_64: W: no-manual-page-for-binary stringsx file-unpack.x86_64: W: no-manual-page-for-binary unpack-deep file-unpack.x86_64: W: no-manual-page-for-binary unpack-file file-unpack.x86_64: W: no-manual-page-for-binary unpack-file-deep perl-File-Unpack2.x86_64: E: no-binary perl-File-Unpack2.spec:188: W: make-check-outside-check-section rm contrib/stringsx # so that the Manifest in make check is not confused. perl-File-Unpack2.spec:188: W: make-check-outside-check-section rm contrib/stringsx # so that the Manifest in make check is not confused. perl-File-Unpack2.spec:195: W: macro-in-comment %{__make} perl-File-Unpack2.spec:195: W: macro-in-comment %{__make} perl-File-Unpack2.spec: W: invalid-url Source0: perl-File-Unpack2-4bcdc19-repackaged.tar.gz perl-File-Unpack2.spec: W: invalid-url Source0: perl-File-Unpack2-4bcdc19-repackaged.tar.gz file-unpack.x86_64: W: dangling-relative-symlink /usr/bin/file-unpack-deep file-unpack2 file-unpack.x86_64: W: dangling-relative-symlink /usr/bin/file_unpack file-unpack2 file-unpack.x86_64: W: dangling-relative-symlink /usr/bin/unpack-deep file-unpack2 file-unpack.x86_64: W: dangling-relative-symlink /usr/bin/unpack-file file-unpack2 file-unpack.x86_64: W: dangling-relative-symlink /usr/bin/unpack-file-deep file-unpack2 file-unpack.x86_64: W: dangling-relative-symlink /usr/share/man/man1/unpack_file2.1.gz file-unpack.1.gz = 3 packages and 1 specfiles checked; 19 errors, 18 warnings, 9 filtered, 19 badness; has taken 0.5 s = TODO: Escape a percent character in a comment in %check section (perl-File-Unpack2.spec:195). $ rpm -q --requires -p ../RPMS/x86_64/perl-File-Unpack2-1.0-1.fc40.x86_64.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 /usr/bin/sh 1 binutils 1 bzip2 1 cabextract 1 cpio 1 file >= 5.03 1 genisoimage 1 gzip 1 lzip 1 p7zip-plugins 1 perl(BSD::Resource) 1 perl(Carp) 1 perl(Compress::Raw::Bzip2) 1 perl(Compress::Raw::Lzma) 1 perl(Compress::Raw::Zlib) >= 2.024 1 perl(Config) 1 perl(Cwd) 1 perl(Data::Dumper) 1 perl(File::Compare) 1 perl(File::Copy) 1 perl(File::LibMagic) 1 perl(File::MimeInfo::Magic) 1 perl(File::Path) 1 perl(File::Temp) 1 perl(File::Unpack2) 1 perl(Filesys::Statvfs) 1 perl(FindBin) 1 perl(Getopt::Long) 1 perl(IPC::Run) 1 perl(JSON) 1 perl(lib) 1 perl(Pod::Usage) 1 perl(POSIX) 1 perl(strict) 1 perl(String::ShellQuote) 1 perl(Text::Sprintf::Named) 1 perl(warnings) 1 perl-libs 1 poppler-utils 1 rpm 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 shared-mime-info >= 0.60 1 sharutils 1 tar 1 unzip 1 xz $ rpm -q --requires -p ../RPMS/x86_64/file-unpack-1.0-1.fc40.x86_64.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 perl(Data::Dumper) 1 perl(File::Unpack2) 1 perl(FindBin) 1 perl(Getopt::Long) 1 perl(lib) 1 perl(Pod::Usage) 1 perl-File-Unpack2(x86-64) = 1.0-1.fc40 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary requires are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-File-Unpack2-1.0-1.fc40.x86_64.rpm ../RPMS/x86_64/file-unpack-1.0-1.fc40.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 40 (https://koji.fedoraproject.org/koji/taskinfo?taskID=112610071). Ok. Please consider fixing the TODO items before building this package. Package APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2251479 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251479%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
