https://bugzilla.redhat.com/show_bug.cgi?id=2260080 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Is there a point in installing non-Linux platform files in %{_datadir}/lqml/platforms (android, ios, etc.)? The same question goes for the readme files for those platforms, and for non-Linux platform files in the examples. - The file examples/wear-os-heart/qt-sensor-hack/QtActivity.java is included in the examples subpackage. It carries a BSD-2-Clause license. Add that to the License field for the examples subpackage. - The spec file mentions removing examples with font files, but there is still one: examples/advanced-qml-auto-reload/qml, which has TTF files in a fonts subdirectory. - See the EXTRA item below: "Large data in /usr/share should live in a noarch subpackage if package is arched." Should the examples package be noarch? - Note the hidden-file-or-dir rpmlint warnings. Are those files necessary? - Note the files-duplicate rpmlint warnings. Is there some way to avoid the duplication? ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 0-Clause License", "GNU General Public License, Version 2 and/or GNU Lesser General Public License, Version 3", "BSD 2-Clause License", "MIT License". 677 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20232 bytes in 10 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. examples/advanced-qml-auto-reload/qml contains TTF files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2519040 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: lqml-0^21012024.4847dea7-1.fc40.x86_64.rpm lqml-examples-0^21012024.4847dea7-1.fc40.x86_64.rpm lqml-debuginfo-0^21012024.4847dea7-1.fc40.x86_64.rpm lqml-debugsource-0^21012024.4847dea7-1.fc40.x86_64.rpm lqml-0^21012024.4847dea7-1.fc40.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp734iljwf')] checks: 32, packages: 5 lqml.src: E: spelling-error ('macOS', '%description -l en_US macOS -> ma Cos, mac OS, mac-OS') lqml.x86_64: W: no-manual-page-for-binary lqml lqml-examples.x86_64: W: no-documentation lqml-examples.x86_64: E: no-binary lqml.x86_64: W: hidden-file-or-dir /usr/share/lqml/slime/.swank.lisp lqml-examples.x86_64: W: hidden-file-or-dir /usr/share/lqml/examples/advanced-qml-auto-reload/qml/.create-qml-loaders.lisp lqml-examples.x86_64: W: hidden-file-or-dir /usr/share/lqml/examples/advanced-qml-auto-reload/qml/.ext lqml-examples.x86_64: W: hidden-file-or-dir /usr/share/lqml/examples/advanced-qml-auto-reload/qml/.ext lqml-examples.x86_64: W: hidden-file-or-dir /usr/share/lqml/examples/advanced-qml-auto-reload/qml/.template.qml lqml.x86_64: W: files-duplicate /usr/share/lqml/platforms/macos/patch/howto-toolchain.prf.txt /usr/share/lqml/platforms/ios/patch/howto-toolchain.prf.txt lqml-examples.x86_64: W: files-duplicate /usr/share/lqml/examples/app-template/lisp/package.lisp /usr/share/lqml/examples/advanced-qml-auto-reload/lisp/package.lisp lqml-examples.x86_64: W: files-duplicate /usr/share/lqml/examples/app-template/run.lisp /usr/share/lqml/examples/advanced-qml-auto-reload/run.lisp lqml-examples.x86_64: W: files-duplicate /usr/share/lqml/examples/wear-os-heart/build-android/connect.sh /usr/share/lqml/examples/wear-os-gps/build-android/connect.sh lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/camera/cpp/qt.cpp lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/camera/cpp/qt.h lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/wear-os-gps/cpp/qt.cpp lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/wear-os-gps/cpp/qt.h lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/wear-os-heart/cpp/qt.cpp lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/wear-os-heart/cpp/qt.h ========== 5 packages and 0 specfiles checked; 2 errors, 17 warnings, 21 filtered, 2 badness; has taken 0.5 s ========== Rpmlint (debuginfo) ------------------- Checking: lqml-debuginfo-0^21012024.4847dea7-1.fc40.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpvf5_aokw')] checks: 32, packages: 1 =========== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s =========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 lqml.x86_64: W: no-manual-page-for-binary lqml lqml-examples.x86_64: W: no-documentation lqml-examples.x86_64: E: no-binary lqml-examples.x86_64: W: hidden-file-or-dir /usr/share/lqml/examples/advanced-qml-auto-reload/qml/.create-qml-loaders.lisp lqml-examples.x86_64: W: hidden-file-or-dir /usr/share/lqml/examples/advanced-qml-auto-reload/qml/.ext lqml-examples.x86_64: W: hidden-file-or-dir /usr/share/lqml/examples/advanced-qml-auto-reload/qml/.ext lqml-examples.x86_64: W: hidden-file-or-dir /usr/share/lqml/examples/advanced-qml-auto-reload/qml/.template.qml lqml.x86_64: W: hidden-file-or-dir /usr/share/lqml/slime/.swank.lisp lqml-examples.x86_64: W: files-duplicate /usr/share/lqml/examples/app-template/lisp/package.lisp /usr/share/lqml/examples/advanced-qml-auto-reload/lisp/package.lisp lqml-examples.x86_64: W: files-duplicate /usr/share/lqml/examples/app-template/run.lisp /usr/share/lqml/examples/advanced-qml-auto-reload/run.lisp lqml-examples.x86_64: W: files-duplicate /usr/share/lqml/examples/wear-os-heart/build-android/connect.sh /usr/share/lqml/examples/wear-os-gps/build-android/connect.sh lqml.x86_64: W: files-duplicate /usr/share/lqml/platforms/macos/patch/howto-toolchain.prf.txt /usr/share/lqml/platforms/ios/patch/howto-toolchain.prf.txt lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/camera/cpp/qt.cpp lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/camera/cpp/qt.h lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/wear-os-gps/cpp/qt.cpp lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/wear-os-gps/cpp/qt.h lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/wear-os-heart/cpp/qt.cpp lqml-examples.x86_64: W: devel-file-in-non-devel-package /usr/share/lqml/examples/wear-os-heart/cpp/qt.h 4 packages and 0 specfiles checked; 1 errors, 17 warnings, 17 filtered, 1 badness; has taken 0.4 s Source checksums ---------------- https://gitlab.com/eql/lqml/-/archive/4847dea734c8ae2e1b3cfd06d7027e882ebfa95a/lqml-4847dea7.tar.gz : CHECKSUM(SHA256) this package : e0a05f6b085b99294e426e0c9dce80c9c818ad6043ca9174ca619339ad975f28 CHECKSUM(SHA256) upstream package : e0a05f6b085b99294e426e0c9dce80c9c818ad6043ca9174ca619339ad975f28 Requires -------- lqml (rpmlib, GLIBC filtered): /usr/bin/sh libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5QuickControls2.so.5()(64bit) libQt5QuickControls2.so.5(Qt_5)(64bit) libc.so.6()(64bit) libecl.so.23.9()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) lqml-examples (rpmlib, GLIBC filtered): /usr/bin/python3 lqml-debuginfo (rpmlib, GLIBC filtered): lqml-debugsource (rpmlib, GLIBC filtered): Provides -------- lqml: lqml lqml(x86-64) lqml-examples: lqml-examples lqml-examples(x86-64) lqml-debuginfo: debuginfo(build-id) lqml-debuginfo lqml-debuginfo(x86-64) lqml-debugsource: lqml-debugsource lqml-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2260080 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: R, Python, Perl, Haskell, Java, Ocaml, SugarActivity, Ruby, PHP, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2260080 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260080%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
