[Bug 2260856] Review Request: python-ftputil High-level FTP client library (virtual file system and more)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2260856



--- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Thank you for the review!

(In reply to Steve Cossette from comment #1)
> 
> NOTES: The %tests do come out with a warning, seems one of the tests may be
> wrongly wired? But again, not a concern, just a note:
> 
> =============================== warnings summary
> ===============================
> test/test_public_servers.py:175
>   /builddir/build/BUILD/ftputil-5.1.0/test/test_public_servers.py:175:
> PytestUnknownMarkWarning: Unknown pytest.mark.slow_test - is this a typo? 
> You can register custom marks to avoid this warning - for details, see
> https://docs.pytest.org/en/stable/how-to/mark.html
>     @pytest.mark.slow_test
> -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

Good eye. This happens because the mark is defined in tox.ini,

  https://git.sr.ht/~sschwarzer/ftputil/tree/v5.0.4/item/tox.ini#L9

but tox.ini isn’t included in the PyPI sdist that I use as the source archive.

I decided it wasn’t important enough to do anything about it, but I suppose I
could ask upstream to include tox.ini in the sdist, which would make the
warning disappear and would make it easy to generate the BuildRequires for
testing.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2260856

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260856%23c2
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux