https://bugzilla.redhat.com/show_bug.cgi?id=2259250 --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Tom Rix from comment #3) > Lets wait on the license feedback. > IMO the github page says GPL 3. > The text in the code is not great, but it doesn't say 1 and later. I have > very very rarely seen gpl1. Upstream has released version 1.0.1 with improved license information. It is GPL-3.0-or-later. The old licensing docs used to say that if you can't find a clear statement about which version of the GPL is intended, then any version of the GPL can be used; i.e., the license defaults to GPL-1.0-or-later. I can't find that in the new licensing docs, so maybe that is not the case anymore. > if there are no ctests dont use them, just remove %check. I commented it out for now so that I remember to look later to see if any tests have been added. > for the %files list, i like to see it to be boring and reflect what is in > the buildroot. I don't think I understand what it is you want me to do, or what you see as a deficiency in the way I have it now. Can you explain a little more, please? > I have this shiny new package review to get automatic speech recognition > going > https://bugzilla.redhat.com/show_bug.cgi?id=2259336 Okay, I will review it. New URLs for version 1.0.1: Spec URL: https://jjames.fedorapeople.org/HPCombi/HPCombi.spec SRPM URL: https://jjames.fedorapeople.org/HPCombi/HPCombi-1.0.1-1.fc40.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2259250 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259250%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
