Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: coriander - Control a 1394 digital camera interactively https://bugzilla.redhat.com/show_bug.cgi?id=428959 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2008-01-18 09:11 EST ------- Full review done, results: Must Fix -------- - Remove the following lines from src/build_menus.c: // add edge sense option glade_menuitem = gtk_menu_item_new_with_label (_("Edge Sense")); gtk_widget_show (glade_menuitem); gtk_menu_append (GTK_MENU (new_menu), glade_menuitem); g_signal_connect ((gpointer) glade_menuitem, "activate", G_CALLBACK (on_bayer_menu_activate), (int*)DC1394_BAYER_METHOD_EDGESENSE); As libdc1394-2.0.1 no longer supports this - Change Release to "0.4.rc5%{?cvs_snapshot}%{?dist}", as per the versioning guidelines so that upgrading to 2.0.0 final can happen without epoch. - Drop the unnecessary explicit: "Requires: libdc1394 >= 2.0.0" 2.0.0 has a different soname then libdc1394 v1, so there is no need for this. - Reword "and Real streaming" in description, this made me think of Real video (realmedia, .rm files) streaming which is patented. - Don't use an url for cvs snapshots, as those cannot be downloaded from such an URL - Drop buildrequires ffmpeg-devel, we don't have ffmpeg-devel in Fedora - Change "--vendor rpmforge" desktop-file-install argument to "--vendor fedora" and drop the obsolete "--add-category X-Red-Hat-Base" argument - Add (as comment above Source0) instructions on howto recreate the tarbal from CVS (so cvs co command, any commands used to clean the checkout, etc.) Should Fix ---------- - Add an Icon= line to the .desktop fil, install a suitable icon under /usr/share/icons/hicolor/48x48/apps, and add icon cache update scriptlets Not checked ----------- - sources matching due to missing reproduction instructions for the tarbal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review