https://bugzilla.redhat.com/show_bug.cgi?id=2254922 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > URL and Source0 > FIX: Please switch URL and Source0 from search.cpan.org to metacpan.org > https://metacpan.org/dist/Protocol-SOCKS > https://cpan.metacpan.org/authors/id/T/TE/TEAM/Protocol-SOCKS-%{version}.tar.gz Done > BuildRequires > FIX: Add build-require > coreutils - it is needed for %{_fixperms} > perl(constant) - lib/Protocol/SOCKS/Constants.pm:25 > perl(Exporter) - lib/Protocol/SOCKS/Constants.pm:6 > perl(strict) - Makefile.PL:3 > perl(warnings) - Makefile.PL:4 Done > TODO: Use new %make_* macros and remove packlist by ExtUtils::MakeMaker's > variable. > 1) Add > NO_PERLLOCAL=1 NO_PACKLIST=1 > to command > perl Makefile.PL > and remove > find %{buildroot} -type f -name .packlist -exec rm -f {} ';' Done > 2) Replace > make %{?_smp_mflags} > by > %{make_build} Done > 3) Replace > make pure_install PERL_INSTALL_ROOT=%{buildroot} > by > %{make_install} Done > 4) Add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > NO_PACKLIST is provided since this version. Done The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2254922 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254922%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
