https://bugzilla.redhat.com/show_bug.cgi?id=2257184 --- Comment #7 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #5) > > Additionally, the crate includes a bunch of shell scripts and files that are only useful for upstream. These should be excluded from getting installed into the -devel package. > > Looks like you missed this? > > Please exclude at least the "ci" directory from the installed files, and > possibly also "tests/*.sh", "tests/valgrind.supp", "tests/*.h", and also the > "bindgen" directory, since it will end up unused unconditionally. > > So something like this would be great: > > ```toml > [package] > # ... > exclude = [ > "/bindgen/", > "/ci/", > "/tests/*.sh", > "/tests/*.h", > "/tests/valgrind.supp", > ] > # ... > ``` > > Otherwise, package looks good to me. > Ah yes, thanks! Also regenerated the spec to include the bindgen feature subpackage (which does nothing) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2257184 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257184%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
