https://bugzilla.redhat.com/show_bug.cgi?id=2259417 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED Flags| |fedora-review? Doc Type|--- |If docs needed, set a value --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- There's some minor issues: - Looks like the PR to ship the license file is merged upstream, can you include a link to the upstream commit? - Please don't reference file blobs from the "master" branch, instead use a specific commit. References to branches are not stable over time. - Use `%license %{crate_instdir}/LICENSE` instead of `%license LICENSE` - otherwise the file will get installed twice (once to `%crate_instdir`, once to `/usr/share/licenses/%{name}/LICENSE`). - Use `-p` flag for copying the LICENSE file to the build directory to preserve the timestamp. There's also a typo in the comment that you added above the patch (s/interessted/interested/). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2259417 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259417%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
