[Bug 2244124] Review Request: crow-translate - A simple and lightweight translator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2244124



--- Comment #11 from Artem <ego.cordatus@xxxxxxxxx> ---
(In reply to Beck Liu from comment #10)
> 1. update to the latest release for now.

Done. 

> 2. I think the licenses listed are not correct. Since the bundled
> dependencies are not avoidable, so you should add their licenses to license
> field.

Indeed, fixed.

> 3.
> > %global appid io.crow_translate.CrowTranslate
> 
> The variable is not used.

Fixed.

Thanks for review!

---

https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-rawhide-x86_64/06947009-crow-translate/crow-translate.spec
https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-rawhide-x86_64/06947009-crow-translate/crow-translate-2.11.1-1.fc40.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2244124

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244124%23c11
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux