https://bugzilla.redhat.com/show_bug.cgi?id=2259263 Tim Flink <tflink@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Keywords|AutomationTriaged | --- Comment #11 from Tim Flink <tflink@xxxxxxxxxx> --- (In reply to Tom Stellard from comment #7) > (In reply to Tim Flink from comment #6) > > (In reply to Tom Rix from comment #3) > > > Spec URL: https://trix.fedorapeople.org/hipsolver.spec > > > SRPM URL: https://trix.fedorapeople.org/hipsolver-6.0.0-2.fc40.src.rpm > > > > > > 1. clang-devel pulls in clang. > > > > I agree that it's redundant and probably not what the guidelines meant to > > enforce but that doesn't change what the packaging guidelines say. > > > > "If your application is a C or C++ application you must list a BuildRequires > > against gcc, gcc-c++ or clang." > > > > The other reason to explicitly BuildRquires: clang is because clang-devel > may not always pull in clang. Right now clang-devel pulling in clang is > just a workaround for an issue with the CMake export files, but it's > something we would like to fix. Good to know, thanks. Package LGTM. I'd suggest putting -b 3 after autorelease to make sure that the official builds supercede any of the previous review versions but it's not critical. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2259263 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259263%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
