https://bugzilla.redhat.com/show_bug.cgi?id=2257069 Tim Flink <tflink@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tflink@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |tflink@xxxxxxxxxx --- Comment #5 from Tim Flink <tflink@xxxxxxxxxx> --- A few small things: 1. "BuildRequires: clang" to satisfy https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ 2. all the rocm subprojects were consolidated into a single github project and the base url needs to be updated- https://github.com/ROCm/ 3. this is a snapshot (that will eventually be 6.0.1 once that's released) and thus, the version should be 6.0.0.git%{shortcommit} or 6.0.0.%{shortcommit} - https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots I'm still running the test suite but everything is passing so far and I don't anticipate any problems -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2257069 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257069%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
