https://bugzilla.redhat.com/show_bug.cgi?id=2259250 --- Comment #3 from Tom Rix <trix@xxxxxxxxxx> --- Lets wait on the license feedback. IMO the github page says GPL 3. The text in the code is not great, but it doesn't say 1 and later. I have very very rarely seen gpl1. if there are no ctests dont use them, just remove %check. for the %name.. ok i guess. for the %files list, i like to see it to be boring and reflect what is in the buildroot. I have this shiny new package review to get automatic speech recognition going https://bugzilla.redhat.com/show_bug.cgi?id=2259336 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2259250 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259250%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
