https://bugzilla.redhat.com/show_bug.cgi?id=2259263 Tim Flink <tflink@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tflink@xxxxxxxxxx --- Comment #2 from Tim Flink <tflink@xxxxxxxxxx> --- A few small things: 1. "BuildRequires: clang" to satisfy https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ 2. all the rocm subprojects were consolidated into a single github project and the base url needs to be updated- https://github.com/ROCm/ 3. Source0 should drop the /refs/tags/ per https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags 4. shouldn't CMAKE_BUILD_TYPE be RelWithDebInfo ? The larger issue(s) is that I can't get the tests to pass on my machine. Most, if not all of them fail but I get a segfault before the suite finishes. Are you able to get the tests to pass? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2259263 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259263%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
