[Bug 2259302] Review Request: python-sysrsync - Simple and safe python wrapper for calling system rsync

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2259302



--- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Thank you for the review!

(In reply to Benson Muite from comment #4)
> Comments:
> a) Koji build https://koji.fedoraproject.org/koji/taskinfo?taskID=112022873
> b) Upon import can remove
> %license LICENSE
> from the spec file. License is duplicated and is correctly identified:
> rpm -qL python3-sysrsync-1.1.1-1.fc40.noarch.rpm
> /usr/lib/python3.12/site-packages/sysrsync-1.1.1.dist-info/LICENSE
> /usr/share/licenses/python3-sysrsync/LICENSE

Good catch, thanks! I will also add the -l option to %pyproject_save_files.

> c) Approved.
> d) Review of https://bugzilla.redhat.com/show_bug.cgi?id=2258595 or
> https://bugzilla.redhat.com/show_bug.cgi?id=2258796 would be appreciated if
> time and expertise allow.

I’ve taken at least bug 2258595, and I’m investigating bug 2258796.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2259302

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259302%23c5
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux