https://bugzilla.redhat.com/show_bug.cgi?id=2259199 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? CC| |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package looks pretty good, I just have two questions: - You are using "ExcludeArch: %{ix86}", can you explain why? Just because you don't want to build an application for i686 and it's not a library that can be used by other Rust programs? - Why are you changing the Summary / description? We usually only override those from Cargo.toml metadata if the upstream description is really bad and / or the heuristics for generating a short (<72 characters) summary from a long description string fail. You wrote a whole new description instead. In that case, I would rather update the description in Cargo.toml to be more descriptive and submit that as a PR to upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2259199 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259199%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
