https://bugzilla.redhat.com/show_bug.cgi?id=2259075 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- I see three minor issues: 1. You added "ExcludeArch: %{ix86}", is there a reason for that? Or do you just not want to bother building for an architecture that is on life-support? If that *is* the reason, that is fine, since this is a binary-only Rust crate and no other Rust packages can depend on it - I just want to make sure. 2. Please include the full output of the %cargo_license_summary macro as a comment in the spec file, as suggested by the generated FIXME comment. The list is much more informative than the ANDed license tag below. 3. The license tag for the binary subpackage is more complicated than it needs to be. The AND and OR operators in SPDX are commutative and associative, so you can do the following: - Drop parentheses around "((MIT OR Apache-2.0) AND Unicode-DFS-2016)" since "(A AND B) AND C" is the same as "A AND B AND C". - Drop "(MIT OR Apache-2.0)", you already have "(Apache-2.0 OR MIT)". - Reorder to be in alphabetical order so there's a consistent order (I usually do items without parenthesized OR clauses in alphabetical order first, then the parenthesized items in alphabetical order). That should make the License tag a bit more readable and a bit shorter as well. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2259075 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202259075%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
