https://bugzilla.redhat.com/show_bug.cgi?id=2258110 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra | |in.net) | --- Comment #15 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- I haven’t done a full re-review, but I think everything will be OK except for these two quibbles: You can replace “To be submitted as PR” with a link to the actual PR, https://github.com/wkz/phytool/pull/15. (I wouldn’t block the review on that.) More importantly, you can and should fix the EPEL9 debuginfo problem by ensuring the correct distribution compiler flags are set: add %set_build_flags as the first line of %build. This is automatic in Fedora since https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck, but there is no harm in doing it twice. (You don’t have to worry about this with %cmake, %configure, etc., because those macros set the build flags, but %make_install does not.) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2258110 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202258110%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
