https://bugzilla.redhat.com/show_bug.cgi?id=2255637 --- Comment #3 from Tom Rix <trix@xxxxxxxxxx> --- (In reply to Sergio Pascual from comment #2) > Package Review > ============== > > %check section is missing and the python guidelines specify that at least a > smoke test must be run there. > > > You can add something like this after pyproject_install > > > %pyproject_save_files %{pypi_name} > > %check > %pyproject_check_import > > With this appears a missing dependecy on "chainer". > If this failure is expected you can exclude "einops.layers.chainer" passing > flags to pyproject_check_import > Thanks for pointing this out, this is a problem. I have filed a package review for chainer, it's the depends-on bz 2259226. There is at least one more after that, flax. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2255637 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255637%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
