https://bugzilla.redhat.com/show_bug.cgi?id=2257209 --- Comment #2 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #1) > Four minor issues that don't block the review, but please address them: > > 1. The uploaded spec file and spec file extracted from uploaded srpm are > different: > > @@ -14,5 +14,4 @@ > Source: %{crates_source} > # Manually created patch for downstream crate metadata changes > -# * bump rstest from 0.17.0 to 0.18.0 > Patch: notify-debouncer-full-fix-metadata.diff > > Please ensure to import the version that has that comment. Ack, sorry. Must have forgotten to regenerate the SRPM > > 2. Please submit that change as a PR for upstream, if the change has not > already been applied there. > Done: https://github.com/notify-rs/notify/pull/556 > 3. W: wrong-file-end-of-line-encoding > /usr/share/cargo/registry/notify-debouncer-full-0.3.1/README.md > > Use something like "dos2unix --keepdate" to convert the file to unix line > endings. > Will do, thanks. adding a BR on dos2unix then (thanks rust2rpm.toml) > 4. The "test_cases" directory should probably be excluded from packaged > files. > > You can use %exclude %{crate_instdir}/test_cases/ in the %files section of > the -devel subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2257209 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257209%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
