https://bugzilla.redhat.com/show_bug.cgi?id=2258212 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is based on the output of rust2rpm, simplifying the review. The following changes are noted: - The first letter of the Summary and description text is lower-cased. This is a reasonable change to do downstream if you believe the name of the command should always have the same case as the executable. - The actual license text and license breakdown are correctly filled in. - The binary is renamed from wc to uu_wc; this is an appopriate downstream-ony change to avoid conflicts with wc from GNU coreutils. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/licenses/uu_wc/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is due to rust2rpm listing the entire %{crate_instdir}/ and then separately listing some of its contents as %doc/%license. The duplication appears to be harmless; if it is a problem, then it should be fixed in rust2rpm. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 13 files have unknown license. Detailed output of licensecheck in /home/ben/Downloads/review/2258212-rust-uu_wc/licensecheck.txt [x]: License file installed when any subpackage combination is installed. Importantly, *both* license files are correctly handled. $ rpm -qL -p results/rust-uu_wc-devel-0.0.23-1.fc40.noarch.rpm /usr/share/cargo/registry/uu_wc-0.0.23/LICENSE /usr/share/cargo/registry/uu_wc-0.0.23/src/utf8/LICENSE [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. (The LICENSE in src/utf8/ suggests the contents of that directory may be derived from another project, but they do not appear to be *copied* or bundled.) [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5716 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in uu_wc , rust-uu_wc-devel , rust-uu_wc+default-devel [x]: Package functions as described. Since there are no tests from upstream, I did a simple smoke test: <mock-chroot> sh-5.2# wc -l /usr/share/dict/words 479826 /usr/share/dict/words <mock-chroot> sh-5.2# uu_wc -l /usr/share/dict/words 479826 /usr/share/dict/words [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=111898162 (this shows a spurious/random x86_64 failure unrelated to the package contents, but I reviewed on x86_64, so I know it works there) [x]: %check is present and all tests pass. Upstream does not actually provide any tests (“running 0 tests”), but the spec file provides all the necessary machinery to build and run them if some tests do appear in a future release. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: uu_wc-0.0.23-1.fc40.x86_64.rpm rust-uu_wc-devel-0.0.23-1.fc40.noarch.rpm rust-uu_wc+default-devel-0.0.23-1.fc40.noarch.rpm rust-uu_wc-debugsource-0.0.23-1.fc40.x86_64.rpm rust-uu_wc-0.0.23-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpuwfywvrf')] checks: 31, packages: 5 rust-uu_wc+default-devel.noarch: W: summary-not-capitalized wc ~ (uutils) display newline, word, and byte counts for input rust-uu_wc.src: W: summary-not-capitalized wc ~ (uutils) display newline, word, and byte counts for input rust-uu_wc-devel.noarch: W: summary-not-capitalized wc ~ (uutils) display newline, word, and byte counts for input uu_wc.x86_64: W: summary-not-capitalized wc ~ (uutils) display newline, word, and byte counts for input uu_wc.x86_64: W: no-manual-page-for-binary uu_wc >>>> https://bugzilla.redhat.com/show_bug.cgi?id=2258213#c2 rust-uu_wc+default-devel.noarch: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 uu_wc.x86_64: W: unused-direct-shlib-dependency /usr/bin/uu_wc /lib64/libm.so.6 >>>> I’m not sure why libm is linked without using it, but I don’t view this as a serious defect. rust-uu_wc-devel.noarch: W: summary-not-capitalized wc ~ (uutils) display newline, word, and byte counts for input uu_wc.x86_64: W: summary-not-capitalized wc ~ (uutils) display newline, word, and byte counts for input rust-uu_wc+default-devel.noarch: W: summary-not-capitalized wc ~ (uutils) display newline, word, and byte counts for input rust-uu_wc-devel.noarch: E: spelling-error ('uutils', 'Summary(en_US) uutils -> utilizes') rust-uu_wc-devel.noarch: E: spelling-error ('uutils', '%description -l en_US uutils -> utilizes') uu_wc.x86_64: E: spelling-error ('uutils', 'Summary(en_US) uutils -> utilizes') uu_wc.x86_64: E: spelling-error ('uutils', '%description -l en_US uutils -> utilizes') rust-uu_wc+default-devel.noarch: E: spelling-error ('uutils', 'Summary(en_US) uutils -> utilizes') rust-uu_wc+default-devel.noarch: E: spelling-error ('uutils', '%description -l en_US uutils -> utilizes') uu_wc.x86_64: W: no-manual-page-for-binary uu_wc >>>> https://bugzilla.redhat.com/show_bug.cgi?id=2258213#c2 rust-uu_wc+default-devel.noarch: W: no-documentation 4 packages and 0 specfiles checked; 6 errors, 6 warnings, 15 filtered, 6 badness; has taken 0.2 s Source checksums ---------------- https://crates.io/api/v1/crates/uu_wc/0.0.23/download#/uu_wc-0.0.23.crate : CHECKSUM(SHA256) this package : c86f83898f2649cdf2822508cbf4cc56911b995f60532bf893ac869d98c9e2f5 CHECKSUM(SHA256) upstream package : c86f83898f2649cdf2822508cbf4cc56911b995f60532bf893ac869d98c9e2f5 Requires -------- uu_wc (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) rtld(GNU_HASH) rust-uu_wc-devel (rpmlib, GLIBC filtered): (crate(bytecount/default) >= 0.6.7 with crate(bytecount/default) < 0.7.0~) (crate(clap/cargo) >= 4.4.0 with crate(clap/cargo) < 5.0.0~) (crate(clap/default) >= 4.4.0 with crate(clap/default) < 5.0.0~) (crate(clap/wrap_help) >= 4.4.0 with crate(clap/wrap_help) < 5.0.0~) (crate(libc/default) >= 0.2.150 with crate(libc/default) < 0.3.0~) (crate(nix) >= 0.27.0 with crate(nix) < 0.28.0~) (crate(thiserror/default) >= 1.0.0 with crate(thiserror/default) < 2.0.0~) (crate(unicode-width/default) >= 0.1.11 with crate(unicode-width/default) < 0.2.0~) cargo crate(uucore/default) crate(uucore/pipes) crate(uucore/quoting-style) rust-uu_wc+default-devel (rpmlib, GLIBC filtered): cargo crate(uu_wc) rust-uu_wc-debugsource (rpmlib, GLIBC filtered): Provides -------- uu_wc: uu_wc uu_wc(x86-64) rust-uu_wc-devel: crate(uu_wc) rust-uu_wc-devel rust-uu_wc+default-devel: crate(uu_wc/default) rust-uu_wc+default-devel rust-uu_wc-debugsource: rust-uu_wc-debugsource rust-uu_wc-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2258212 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, Ocaml, SugarActivity, Java, R, Haskell, PHP, Python, fonts, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2258212 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202258212%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
