https://bugzilla.redhat.com/show_bug.cgi?id=2258271 Michel Lind <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST --- Comment #3 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- (In reply to Ben Beasley from comment #2) > The package is APPROVED, with one recommended change related to patch > upstream status. > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > The spec file is almost exactly as generated by rust2rpm, simplifying the > review. > > I noted the following difference: > > --- ./rust-rlimit.spec 2024-01-16 11:17:46.072293254 -0500 > +++ ../srpm-unpacked/rust-rlimit.spec 2024-01-12 19:00:00.000000000 -0500 > @@ -51,6 +51,8 @@ > > %prep > %autosetup -n %{crate}-%{version} -p1 > +# fix permission, otherwise mangle-shebangs will try and parse this > +chmod -x src/bindings.rs > %cargo_prep > > %generate_buildrequires > > This change makes sense, but it would be better fixed upstream. I opened a > PR: > > Remove spurious executable bit from a Rust source > https://github.com/Nugine/rlimit/pull/59 > > Please consider linking that PR, and perhaps even applying it as a patch > (https://github.com/Nugine/rlimit/pull/59.patch) so that you notice when the > unwanted executable bit goes away in a future release. > Thank you! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2258271 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202258271%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
