https://bugzilla.redhat.com/show_bug.cgi?id=2251482 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- The spec-file diff is diff -Naur ./srpm-unpacked/fawltydeps.spec 2251482-fawltydeps/srpm-unpacked/fawltydeps.spec --- ./srpm-unpacked/fawltydeps.spec 2023-11-24 19:00:00.000000000 -0500 +++ 2251482-fawltydeps/srpm-unpacked/fawltydeps.spec 2024-01-15 19:00:00.000000000 -0500 @@ -1,8 +1,8 @@ ## START: Set by rpmautospec -## (rpmautospec version 0.3.5) +## (rpmautospec version 0.3.8) ## RPMAUTOSPEC: autorelease, autochangelog %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: - release_number = 1; + release_number = 2; base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); print(release_number + base_release_number - 1); }%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} @@ -23,6 +23,8 @@ BuildArch: noarch BuildRequires: python3-devel +# For generating man pages +BuildRequires: help2man %if %{with tests} BuildRequires: python3-pytest BuildRequires: python3-hypothesis @@ -35,8 +37,6 @@ %description %_description -Provides: python3-%{name}-%{version} - %prep %forgeautosetup -p1 @@ -61,6 +61,13 @@ %pyproject_install %pyproject_save_files %{name} +# Create man pages from --help and --version +mkdir man +%{py3_test_envvars} help2man --section 1 --no-discard-stderr \ +--no-info --output man/%{name}.1 %{name} +mkdir -p %{buildroot}%{_mandir}/man1 +install -m 0644 man/%{name}.1 %{buildroot}%{_mandir}/man1 + %check %if %{with tests} @@ -79,8 +86,14 @@ %doc README.* %license LICENSE %{_bindir}/%{name} +%{_mandir}/man1/%{name}.1* %changelog +## START: Generated by rpmautospec +* Tue Jan 16 2024 Sandro <devel@xxxxxxxxxxxxx> - 0.13.3-2 +- Add man page and drop Provides: + * Sat Nov 25 2023 Sandro <devel@xxxxxxxxxxxxx> - 0.13.3-1 - Initial package +## END: Generated by rpmautospec This correctly implements the requested changes. Furthermore, the rpmlint output in the new review.txt template does not reveal any new issues: Rpmlint ------- Checking: fawltydeps-0.13.3-2.fc40.noarch.rpm fawltydeps-0.13.3-2.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpe1x63j0s')] checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 fawltydeps.noarch: W: python-missing-require importlib_metadata fawltydeps.noarch: W: python-missing-require isort fawltydeps.noarch: W: python-missing-require pip-requirements-parser fawltydeps.noarch: W: python-missing-require pydantic fawltydeps.noarch: W: python-missing-require setuptools 1 packages and 0 specfiles checked; 0 errors, 5 warnings, 3 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/tweag/FawltyDeps/archive/v0.13.3/FawltyDeps-0.13.3.tar.gz : CHECKSUM(SHA256) this package : d4036fd3a3bd9b08526a12ae1eb0e91557c353128c60cb47184fe613c52bcbdd CHECKSUM(SHA256) upstream package : d4036fd3a3bd9b08526a12ae1eb0e91557c353128c60cb47184fe613c52bcbdd Requires -------- fawltydeps (rpmlib, GLIBC filtered): (python3.12dist(isort) < 6~~ with python3.12dist(isort) >= 5.10) (python3.12dist(pip-requirements-parser) < 33~~ with python3.12dist(pip-requirements-parser) >= 32.0.1) (python3.12dist(pydantic) < 3~~ with python3.12dist(pydantic) >= 1.10.2) (python3.12dist(setuptools) < 69~~ with python3.12dist(setuptools) >= 65.5.1) /usr/bin/python3 python(abi) python3.12dist(importlib-metadata) Provides -------- fawltydeps: fawltydeps python3.12dist(fawltydeps) python3dist(fawltydeps) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2251482 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: SugarActivity, Haskell, Perl, C/C++, Ocaml, Java, fonts, PHP, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH The package is therefore APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2251482 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251482%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
