https://bugzilla.redhat.com/show_bug.cgi?id=2257846 --- Comment #3 from jandrlik <jandrlik@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'ASL 1.1 and ASL 2.0 and BSD and BSD with advertising and GPL+ and GPLv2 and GPLv2 with exceptions and IJG and LGPLv2+ and MIT and MPLv2.0 and Public Domain and W3C and zlib and ISC and FTL and RSA'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. The licece is part of each tarball [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/jvm directory is owned by jpackage-tools [-]: %build honors applicable compiler flags or justifies otherwise. Build flags are adjsuted to pass build of OpenJDK [-]: Package contains no bundled libraries without FPC exception. all bundeld libraries are correctly listed and portable jdk was approved by fesco exception [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Uses parallel make %{?_smp_mflags} macro. [-]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://openjdk- sources.osci.io/openjdk21/openjdk-21.0.1+12.tar.xz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ source tarball is generated, script is present [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java-21-openjdk-portable-slowdebug , java-21-openjdk-portable- fastdebug , java-21-openjdk-portable-devel , java-21-openjdk-portable- devel-slowdebug , java-21-openjdk-portable-devel-fastdebug , java-21-openjdk-portable-static-libs , java-21-openjdk-portable- static-libs-slowdebug , java-21-openjdk-portable-static-libs-fastdebug , java-21-openjdk-portable-unstripped , java-21-openjdk-portable-docs , java-21-openjdk-portable-misc , java-21-openjdk-portable-sources [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _jvmdir /usr/lib/jvm, %define debug_package %{nil}, %define __os_install_post %{nil}, %define __brp_strip_static_archive %{nil}, %define is_release_build() %( if [ "%{?1}" == "%{debug_suffix_unquoted}" -o "%{?1}" == "%{fastdebug_suffix_unquoted}" ]; then echo "0" ; else echo "1"; fi ), %define _lto_cflags %{nil}, %define buildoutputdir() %{expand:build/jdk%{featurever}.build%{?1}}, %define installoutputdir() %{expand:install/jdk%{featurever}.install%{?1}}, %define packageoutputdir() %{expand:packages/jdk%{featurever}.packages%{?1}}, %define uniquejavadocdir() %{expand:%{fullversion}.%{_arch}%{?1}}, %define uniquesuffix() %{expand:%{fullversion}.%{_arch}%{?1}}, %define jreportablenameimpl() %(echo %{uniquesuffix ""} | sed "s;%{version}-%{release};\\0.portable%{1}.jre;g" | sed "s;openjdkportable;el;g"), %define jdkportablenameimpl() %(echo %{uniquesuffix ""} | sed "s;%{version}-%{release};\\0.portable%{1}.jdk;g" | sed "s;openjdkportable;el;g"), %define jdkportablesourcesnameimpl() %(echo %{uniquesuffix ""} | sed "s;%{version}-%{release};\\0.portable%{1}.sources;g" | sed "s;openjdkportable;el;g" | sed "s;.%{_arch};.noarch;g"), %define staticlibsportablenameimpl() %(echo %{uniquesuffix ""} | sed "s;%{version}-%{release};\\0.portable%{1}.static-libs;g" | sed "s;openjdkportable;el;g"), %define jreportablearchive() %{expand:%{jreportablenameimpl -- %%{1}}.tar.xz}, %define jdkportablearchive() %{expand:%{jdkportablenameimpl -- %%{1}}.tar.xz}, %define jdkportablesourcesarchive() %{expand:%{jdkportablesourcesnameimpl -- %%{1}}.tar.xz}, %define staticlibsportablearchive() %{expand:%{staticlibsportablenameimpl -- %%{1}}.tar.xz}, %define jreportablename() %{expand:%{jreportablenameimpl -- %%{1}}}, %define jdkportablename() %{expand:%{jdkportablenameimpl -- %%{1}}}, %define jdkportablesourcesname() %{expand:%{jdkportablesourcesnameimpl -- %%{1}}}, %define staticlibsportablename() %{expand:%{jdkportablenameimpl -- %%{1}}}, %define docportablename() %(echo %{uniquesuffix ""} | sed "s;%{version}-%{release};\\0.portable.docs;g" | sed "s;openjdkportable;el;g"), %define docportablearchive() %{docportablename}.tar.xz, %define miscportablename() %(echo %{uniquesuffix ""} | sed "s;%{version}-%{release};\\0.portable.misc;g" | sed "s;openjdkportable;el;g"), %define miscportablearchive() %{miscportablename}.tar.xz, %define jreportablearchiveForFiles() %(echo %{jreportablearchive -- ""}), %define jdkportablearchiveForFiles() %(echo %{jdkportablearchive -- ""}), %define jdkportablesourcesarchiveForFiles() %(echo %{jdkportablesourcesarchive -- ""}), %define staticlibsportablearchiveForFiles() %(echo %{staticlibsportablearchive -- ""}), %define jdkportablesourcesnameForFiles() %(echo %{jdkportablesourcesname -- ""}), %define etcjavadir() %{expand:%{etcjavasubdir}/%{uniquesuffix -- %{?1}}}, %define sdkdir() %{expand:%{uniquesuffix -- %{?1}}}, %define jrelnk() %{expand:jre-%{javaver}-%{origin}-%{version}-%{release}.%{_arch}%{?1}}, %define sdkbindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define jrebindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define java_rpo() %{expand:, %define java_devel_rpo() %{expand:, %define java_static_libs_rpo() %{expand:, %define java_unstripped_rpo() %{expand:, %define java_docs_rpo() %{expand:, %define java_misc_rpo() %{expand:, %define component %(echo %{name} | sed "s;-portable;;g") [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: java-21-openjdk-portable-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-slowdebug-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-fastdebug-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-devel-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-devel-slowdebug-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-devel-fastdebug-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-static-libs-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-static-libs-slowdebug-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-static-libs-fastdebug-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-unstripped-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-docs-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-misc-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-sources-21.0.1.0.12-5.fc40.x86_64.rpm java-21-openjdk-portable-21.0.1.0.12-5.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpn_qq9na0')] checks: 31, packages: 14 java-21-openjdk-portable-devel-fastdebug.x86_64: E: summary-too-long OpenJDK 21 Runtime and Development Environment portable edition optimised with full debugging on java-21-openjdk-portable-devel-slowdebug.x86_64: E: summary-too-long OpenJDK 21 Runtime and Development Environment portable edition unoptimised with full debugging on java-21-openjdk-portable-slowdebug.x86_64: E: summary-too-long OpenJDK 21 Runtime Environment portable edition unoptimised with full debugging on java-21-openjdk-portable-static-libs-fastdebug.x86_64: E: summary-too-long OpenJDK 21 libraries for static linking - portable edition optimised with full debugging on java-21-openjdk-portable-static-libs-slowdebug.x86_64: E: summary-too-long OpenJDK 21 libraries for static linking - portable edition unoptimised with full debugging on java-21-openjdk-portable-unstripped.x86_64: W: summary-ended-with-dot The OpenJDK 21 runtime environment. java-21-openjdk-portable.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-devel.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-devel-fastdebug.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-devel-slowdebug.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-docs.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-fastdebug.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-misc.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-slowdebug.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-sources.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-static-libs.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-static-libs-fastdebug.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-static-libs-slowdebug.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable-unstripped.x86_64: W: only-non-binary-in-usr-lib java-21-openjdk-portable.x86_64: W: no-documentation java-21-openjdk-portable-devel.x86_64: W: no-documentation java-21-openjdk-portable-devel-fastdebug.x86_64: W: no-documentation java-21-openjdk-portable-devel-slowdebug.x86_64: W: no-documentation java-21-openjdk-portable-docs.x86_64: W: no-documentation java-21-openjdk-portable-fastdebug.x86_64: W: no-documentation java-21-openjdk-portable-misc.x86_64: W: no-documentation java-21-openjdk-portable-slowdebug.x86_64: W: no-documentation java-21-openjdk-portable-sources.x86_64: W: no-documentation java-21-openjdk-portable-unstripped.x86_64: W: no-documentation java-21-openjdk-portable.x86_64: E: no-binary java-21-openjdk-portable-docs.x86_64: E: no-binary java-21-openjdk-portable-fastdebug.x86_64: E: no-binary java-21-openjdk-portable-misc.x86_64: E: no-binary java-21-openjdk-portable-slowdebug.x86_64: E: no-binary java-21-openjdk-portable-sources.x86_64: E: no-binary java-21-openjdk-portable-static-libs.x86_64: E: no-binary java-21-openjdk-portable-static-libs-fastdebug.x86_64: E: no-binary java-21-openjdk-portable-static-libs-slowdebug.x86_64: E: no-binary java-21-openjdk-portable-unstripped.x86_64: E: no-binary java-21-openjdk-portable.spec:1105: W: macro-in-comment %{link_type} java-21-openjdk-portable.src: W: invalid-license-exception advertising java-21-openjdk-portable.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-devel.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-devel-fastdebug.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-devel-slowdebug.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-docs.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-fastdebug.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-misc.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-slowdebug.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-sources.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-static-libs.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-static-libs-fastdebug.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-static-libs-slowdebug.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-unstripped.x86_64: W: invalid-license-exception advertising java-21-openjdk-portable-devel-fastdebug.x86_64: E: description-line-too-long This package is optimised with full debugging. Install only as needed and remove ASAP. java-21-openjdk-portable-devel-slowdebug.x86_64: E: description-line-too-long This package is unoptimised with full debugging. Install only as needed and remove ASAP. java-21-openjdk-portable-fastdebug.x86_64: E: description-line-too-long This package is optimised with full debugging. Install only as needed and remove ASAP. java-21-openjdk-portable-slowdebug.x86_64: E: description-line-too-long This package is unoptimised with full debugging. Install only as needed and remove ASAP. java-21-openjdk-portable-sources.x86_64: E: description-line-too-long The OpenJDK 21 full patched sources of portable JDK to build, attach to debuggers or for debuginfo java-21-openjdk-portable-static-libs-fastdebug.x86_64: E: description-line-too-long This package is optimised with full debugging. Install only as needed and remove ASAP. java-21-openjdk-portable-static-libs-slowdebug.x86_64: E: description-line-too-long This package is unoptimised with full debugging. Install only as needed and remove ASAP. 14 packages and 0 specfiles checked; 22 errors, 39 warnings, 22 badness; has taken 18.8 s All isses seems to be justifed or false negatives (due to tarball output of the rpm build and/or debuginfo and fast/slow debug packages as jdk build produce them Requires -------- java-21-openjdk-portable (rpmlib, GLIBC filtered): java-21-openjdk-portable-slowdebug (rpmlib, GLIBC filtered): java-21-openjdk-portable-fastdebug (rpmlib, GLIBC filtered): java-21-openjdk-portable-devel (rpmlib, GLIBC filtered): java-21-openjdk-portable-devel-slowdebug (rpmlib, GLIBC filtered): java-21-openjdk-portable-devel-fastdebug (rpmlib, GLIBC filtered): java-21-openjdk-portable-static-libs (rpmlib, GLIBC filtered): java-21-openjdk-portable-static-libs-slowdebug (rpmlib, GLIBC filtered): java-21-openjdk-portable-static-libs-fastdebug (rpmlib, GLIBC filtered): java-21-openjdk-portable-unstripped (rpmlib, GLIBC filtered): java-21-openjdk-portable-docs (rpmlib, GLIBC filtered): java-21-openjdk-portable-misc (rpmlib, GLIBC filtered): java-21-openjdk-portable-sources (rpmlib, GLIBC filtered): Provides -------- java-21-openjdk-portable: bundled(freetype) bundled(giflib) bundled(harfbuzz) bundled(lcms2) bundled(libjpeg) bundled(libpng) java-21-openjdk-portable java-21-openjdk-portable(x86-64) java-21-openjdk-portable-slowdebug: java-21-openjdk-portable-slowdebug java-21-openjdk-portable-slowdebug(x86-64) java-21-openjdk-portable-fastdebug: java-21-openjdk-portable-fastdebug java-21-openjdk-portable-fastdebug(x86-64) java-21-openjdk-portable-devel: java-21-openjdk-portable-devel java-21-openjdk-portable-devel(x86-64) java-21-openjdk-portable-devel-slowdebug: java-21-openjdk-portable-devel-slowdebug java-21-openjdk-portable-devel-slowdebug(x86-64) java-21-openjdk-portable-devel-fastdebug: java-21-openjdk-portable-devel-fastdebug java-21-openjdk-portable-devel-fastdebug(x86-64) java-21-openjdk-portable-static-libs: java-21-openjdk-portable-static-libs java-21-openjdk-portable-static-libs(x86-64) java-21-openjdk-portable-static-libs-slowdebug: java-21-openjdk-portable-static-libs-slowdebug java-21-openjdk-portable-static-libs-slowdebug(x86-64) java-21-openjdk-portable-static-libs-fastdebug: java-21-openjdk-portable-static-libs-fastdebug java-21-openjdk-portable-static-libs-fastdebug(x86-64) java-21-openjdk-portable-unstripped: java-21-openjdk-portable-unstripped java-21-openjdk-portable-unstripped(x86-64) java-21-openjdk-portable-docs: java-21-openjdk-portable-docs java-21-openjdk-portable-docs(x86-64) java-21-openjdk-portable-misc: java-21-openjdk-portable-misc java-21-openjdk-portable-misc(x86-64) java-21-openjdk-portable-sources: java-21-openjdk-portable-sources java-21-openjdk-portable-sources(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name java-21-openjdk-portable --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: SugarActivity, R, Ocaml, PHP, Perl, Haskell, Python, fonts, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2257846 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257846%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
