https://bugzilla.redhat.com/show_bug.cgi?id=2255917 --- Comment #9 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec-file diff since the previous review is: --- ../../srpm-unpacked/rust-sequoia-chameleon-gnupg.spec 2023-12-25 19:00:00.000000000 -0500 +++ ./srpm-unpacked/rust-sequoia-chameleon-gnupg.spec 2024-01-06 19:00:00.000000000 -0500 @@ -9,7 +9,9 @@ Release: %autorelease Summary: Sequoia's reimplementation of the GnuPG interface -License: GPL-3.0-or-later +# * sequoia-chameleon-gnupg: GPL-3.0-or-later +# * bundled source file from libgpg-error: LGPL-2.1-or-later +License: GPL-3.0-or-later AND LGPL-2.1-or-later URL: https://crates.io/crates/sequoia-chameleon-gnupg Source: %{crates_source} # Manually created patch for downstream crate metadata changes @@ -17,6 +19,8 @@ # * drop features for unavailable crypto backends # * build with OpenSSL crypto backend Patch: sequoia-chameleon-gnupg-fix-metadata.diff +# * backport upstream patch to port from "home-dir" to "shellexpand": +# https://gitlab.com/sequoia-pgp/sequoia-chameleon-gnupg/-/commit/03f23a7 Patch: 0001-port-from-home-dir-to-shellexpand.patch BuildRequires: cargo-rpm-macros >= 24 @@ -49,6 +53,9 @@ License: GPL-3.0-or-later AND Apache-2.0 AND BSD-3-Clause AND BSL-1.0 AND LGPL-2.0-or-later AND MIT AND MPL-2.0 AND Unicode-DFS-2016 AND (0BSD OR MIT OR Apache-2.0) AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (BSD-2-Clause OR Apache-2.0 OR MIT) AND (MIT OR Apache-2.0 OR Zlib) AND (Unlicense OR MIT) # LICENSE.dependencies contains a full license breakdown +# includes a copy of src/err-codes.h.in from libgpg-error (unknown version) +Provides: bundled(libgpg-error) + %description -n %{crate} %{_description} %files -n %{crate} ===== Notes (no change required for approval) ===== - The tests are disabled. Since this package is security-relevant, it would be especially nice to enable the tests at some point. You said: The interprocess crate appears to be used only for *some* integration tests, so with editdistancek and ntest available, I should be able to run most of the test suite. If it’s possible to enable some tests as soon as this is imported, please consider it. - The LGPL-2.1-or-later license term and the virtual Provides for the file src/err-codes.h.in bundled from libgpg-error are now correctly handled. Thanks! - The upstream status for 0001-port-from-home-dir-to-shellexpand.patch is now correctly indicated in the spec file. - You’ve reported doing a best-effort manual audit of the source code that suggests that the SslConnector::builder() is never called, which suggests that the rpmlint message sequoia-chameleon-gnupg.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/gpg-sq SSL_CTX_set_cipher_list may be not be significant to this package. I’m prepared to believe that the whole-program optimization (across crates) may not be be powerful enough to remove the call site in the openssl crate even if it’s unreachable in the binary. I believe all rpmlint can tell is that the SSL_CTX_set_cipher_list symbol is linked. This might still need fixing in the rust-openssl crate, though, for the sake of other programs outside the Sequoia project. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 3", "GNU General Public License v3.0 or later", "*No copyright* GNU General Public License v3.0 or later", "GNU Lesser General Public License v2.1 or later". 212 files have unknown license. Detailed output of licensecheck in /home/ben/Downloads/review/2255917-rust- sequoia-chameleon-gnupg/20240111/2255917-rust-sequoia-chameleon- gnupg/licensecheck.txt [x]: License file installed when any subpackage combination is installed. $ rpm -qL -p results/sequoia-chameleon-gnupg-0.4.0-1.fc40.x86_64.rpm /usr/share/licenses/sequoia-chameleon-gnupg/LICENSE.dependencies /usr/share/licenses/sequoia-chameleon-gnupg/LICENSE.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. Bundling from libgpg-error is documented in accordance with the relevant guidelines. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 21096 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in sequoia- chameleon-gnupg [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. This worked in the initial review; I didn’t do another scratch build because I didn’t see any changes that I expected could break it. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: sequoia-chameleon-gnupg-0.4.0-1.fc40.x86_64.rpm rust-sequoia-chameleon-gnupg-debugsource-0.4.0-1.fc40.x86_64.rpm rust-sequoia-chameleon-gnupg-0.4.0-1.fc40.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpxdynw3yc')] checks: 31, packages: 3 rust-sequoia-chameleon-gnupg.spec:57: W: unversioned-explicit-provides bundled(libgpg-error) sequoia-chameleon-gnupg.x86_64: W: no-manual-page-for-binary gpg-sq sequoia-chameleon-gnupg.x86_64: W: no-manual-page-for-binary gpgv-sq sequoia-chameleon-gnupg.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/gpg-sq SSL_CTX_set_cipher_list ================ 3 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.4 s ================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 sequoia-chameleon-gnupg.x86_64: W: unused-direct-shlib-dependency /usr/bin/gpg-sq /lib64/libsqlite3.so.0 sequoia-chameleon-gnupg.x86_64: W: unused-direct-shlib-dependency /usr/bin/gpgv-sq /lib64/libsqlite3.so.0 sequoia-chameleon-gnupg.x86_64: E: spelling-error ('reimplementation', 'Summary(en_US) reimplementation -> re implementation, re-implementation, implementation') sequoia-chameleon-gnupg.x86_64: E: spelling-error ('reimplementation', '%description -l en_US reimplementation -> re implementation, re-implementation, implementation') sequoia-chameleon-gnupg.x86_64: W: no-manual-page-for-binary gpg-sq sequoia-chameleon-gnupg.x86_64: W: no-manual-page-for-binary gpgv-sq sequoia-chameleon-gnupg.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/gpg-sq SSL_CTX_set_cipher_list 2 packages and 0 specfiles checked; 2 errors, 5 warnings, 7 filtered, 2 badness; has taken 0.3 s Source checksums ---------------- https://crates.io/api/v1/crates/sequoia-chameleon-gnupg/0.4.0/download#/sequoia-chameleon-gnupg-0.4.0.crate : CHECKSUM(SHA256) this package : a11b0fe2e73b22da4a77feef705c4f104b5cd1f7a61914e88c1ca3a5be460c1a CHECKSUM(SHA256) upstream package : a11b0fe2e73b22da4a77feef705c4f104b5cd1f7a61914e88c1ca3a5be460c1a Requires -------- sequoia-chameleon-gnupg (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libsqlite3.so.0()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) rtld(GNU_HASH) rust-sequoia-chameleon-gnupg-debugsource (rpmlib, GLIBC filtered): Provides -------- sequoia-chameleon-gnupg: bundled(libgpg-error) sequoia-chameleon-gnupg sequoia-chameleon-gnupg(x86-64) rust-sequoia-chameleon-gnupg-debugsource: rust-sequoia-chameleon-gnupg-debugsource rust-sequoia-chameleon-gnupg-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2255917 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: SugarActivity, Haskell, fonts, Perl, PHP, R, C/C++, Java, Ocaml, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2255917 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255917%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
