https://bugzilla.redhat.com/show_bug.cgi?id=2244307 Lyes Saadi <fedora@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|NEW |POST --- Comment #12 from Lyes Saadi <fedora@xxxxxxx> --- > Quote from license-fedora2spdx: "the input is already valid SPDX formula". I guess you looking on old one Spec? Indeed ! > Why it mentioned in Fedora guidelines then? https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_spec_file It's for the tox deps, if they exist. Here, they don't : https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros > I am also gladly add you as co-maintainter if you would like? You are good at Python and in general a maintainer who updates packages on time, which is great. Sure! It'll allow us to maintain the Komikku stack together. --- New nitpicks I've found --- Consider dropping i686 : https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval (it also concerns noarch packages it seem) by adding : ``` ExcludeArch: %{ix86} ``` Consider using %autorelease/%autochangelog, they are now recommended in Fedora (but not obligatory) : https://fedoraproject.org/wiki/Changes/Rpmautospec_by_Default Also, you can also remove : ``` %license LICENSE ``` Learned that recently, but the new python tools do that automatically. Test it by doing : ``` rpm -qL python3-colorthief-0.2.1-1.fc40.noarch.rpm ``` -L shows license files ! --- Anyway, all those are only suggestion, the package is thus approved ! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2244307 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244307%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
