[Bug 2244307] Review Request: python-colorthief - Grabs the dominant color or a representative color palette from an image

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2244307



--- Comment #9 from Artem <ego.cordatus@xxxxxxxxx> ---
Thanks!

> License field is not SPDX.

Quote from license-fedora2spdx: "the input is already valid SPDX formula". I
guess you looking on old one Spec?

> Please run smoke tests.

Done.

> The python3dist(pillow) requires isn't needed thanks to the automatic
> dependency generator.

Done.

> The -t option in %pyproject_buildrequires is useless.
Why it mentioned in Fedora guidelines then?
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_spec_file

> Maybe include the demo.py file as documentation? But if it's a hassle,
> don't mind, it isn't that important.

Done.

---

https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-rawhide-x86_64/06888248-python-colorthief/python-colorthief.spec
https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-rawhide-x86_64/06888248-python-colorthief/python-colorthief-0.2.1-1.fc40.src.rpm

---

I am also gladly add you as co-maintainter if you would like? You are good at
Python and in general a maintainer who updates packages on time, which is
great.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244307

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244307%23c9
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux