https://bugzilla.redhat.com/show_bug.cgi?id=2257524 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! Same responses as bug 2257676: (In reply to Ankur Sinha (FranciscoD) from comment #2) > Looks good. XXX APPROVED XXX > > Minor comments: > > - `-l` not used in pyproject_save files? Correct, because license files can only be handled automatically in %{pyproject_files} when the build backend marks them as License-File, which comes from draft PEP 639. Since poetry-core doesn’t do that, this package needs a manual %license LICENSE instead. Note that the following does not show the license file in the .dist-info directory: $ rpm -qL -p results_python-snakemake-interface-executor-plugins/8.1.3/1.fc40/python3-snakemake-interface-executor-plugins-8.1.3-1.fc40~bootstrap.noarch.rpm /usr/share/licenses/python3-snakemake-interface-executor-plugins/LICENSE > - pytest is to be used when not bootstrapped, so the BR can again be moved > into the conditional? Good catch; thanks. I’ll adjust this on import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2257524 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257524%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
