[Bug 2257676] Review Request: python-snakemake-interface-storage-plugins - Stable interface for interactions between Snakemake and its storage plugins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2257676



--- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Thank you for the review!

(In reply to Ankur Sinha (FranciscoD) from comment #2)
> Minor comments:
> 
> - pytest is only used when the package is not being bootstrapped, so the BR
> for it can also go into the conditional

Good catch; thanks. I’ll adjust this on import.

> - noticed we're not using the `-l` flag here with pyproject_save_files

Correct, because license files can only be handled automatically in
%{pyproject_files} when the build backend marks them as License-File, which
comes from draft PEP 639. Since poetry-core doesn’t do that, this package needs
a manual %license LICENSE instead. Note that the following does not show the
license file in the .dist-info directory:

$ rpm -qL -p
results_python-snakemake-interface-storage-plugins/3.0.0/1.fc40/python3-snakemake-interface-storage-plugins-3.0.0-1.fc40~bootstrap.noarch.rpm 
/usr/share/licenses/python3-snakemake-interface-storage-plugins/LICENSE


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2257676

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257676%23c3
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux